june/Top-Bar-Organizer
1
0
Fork 0
mirror of https://gitlab.gnome.org/june/top-bar-organizer.git synced 2026-01-11 16:53:51 +01:00
Code Issues Projects Releases Packages Wiki Activity

Refactor: Rename this.settings to this._settings

Browse source 
Do this to indicate that this is a "private" field.
This commit is contained in:
June 2023-01-29 03:24:17 +01:00
commit 1b5ba38617
No known key found for this signature in database
GPG key ID: 094C2AC34192FA11
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/extension.js
View file

@ -14,7 +14,7 @@ class Extension {
} }
enable() { enable() {
this.settings = ExtensionUtils.getSettings(); this._settings = ExtensionUtils.getSettings();
this._boxOrderManager = new BoxOrderManager.BoxOrderManager(); this._boxOrderManager = new BoxOrderManager.BoxOrderManager();
@ -32,7 +32,7 @@ class Extension {
// Handle changes of configured box orders. // Handle changes of configured box orders.
this._settingsHandlerIds = []; this._settingsHandlerIds = [];
const addConfiguredBoxOrderChangeHandler = (box) => { const addConfiguredBoxOrderChangeHandler = (box) => {
let handlerId = this.settings.connect(`changed::${box}-box-order`, () => { let handlerId = this._settings.connect(`changed::${box}-box-order`, () => {
this.#handleNewItemsAndOrderTopBar(); this.#handleNewItemsAndOrderTopBar();
}); });
this._settingsHandlerIds.push(handlerId); this._settingsHandlerIds.push(handlerId);
@ -50,11 +50,11 @@ class Extension {
// Disconnect signals. // Disconnect signals.
for (const handlerId of this._settingsHandlerIds) { for (const handlerId of this._settingsHandlerIds) {
this.settings.disconnect(handlerId); this._settings.disconnect(handlerId);
} }
this._boxOrderManager.disconnectSignals(); this._boxOrderManager.disconnectSignals();
this.settings = null; this._settings = null;
this._boxOrderManager = null; this._boxOrderManager = null;
} }