june/Top-Bar-Organizer
1
0
Fork 0
mirror of https://gitlab.gnome.org/june/top-bar-organizer.git synced 2026-01-11 08:46:34 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix: Null out this.settings on extension disable

Browse source 
See here for the relevant review:
https://extensions.gnome.org/review/38364
And for the relevant documentation:
https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects
This commit is contained in:
June 2023-01-25 20:40:16 +01:00
commit 2ef16f310c
No known key found for this signature in database
GPG key ID: 094C2AC34192FA11
1 changed files with 2 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/extension.js
View file

@ -76,6 +76,8 @@ class Extension {
for (const handlerId of this._settingsHandlerIds) { for (const handlerId of this._settingsHandlerIds) {
this.settings.disconnect(handlerId); this.settings.disconnect(handlerId);
} }
this.settings = null;
} }
//////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////